refactor: change User and ApiKey classes to public and update asserti…#101
Merged
refactor: change User and ApiKey classes to public and update asserti…#101
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes Java code by using diamond operator syntax for type inference and improves test assertions. It also exposes previously private nested classes for testing purposes.
- Replaced explicit generic type declarations with diamond operator (
<>) in HashMap instantiations - Changed assertions from
assertTrue(collection.size() > 0)toassertFalse(collection.isEmpty())for better readability - Made nested
UserandApiKeyclasses public to enable additional test coverage
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ScaniiClientTest.java | Updated HashMap instantiations to use diamond operator and enhanced account info test with assertions for nested ApiKey properties |
| ScaniiAccountInfo.java | Made nested User and ApiKey classes public and added @SuppressWarnings("unused") annotation |
Comments suppressed due to low confidence (1)
src/test/java/com/uvasoftware/scanii/ScaniiClientTest.java:379
- Actual argument type 'Integer' is incompatible with expected argument type 'String'.
var firstKey = account.getKeys().get(0);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ons in tests